fix(_transform): guard IndexError for bare dict annotation#3339
Open
devteamaegis wants to merge 1 commit into
Open
fix(_transform): guard IndexError for bare dict annotation#3339devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
…tion When a TypedDict field is annotated with a bare `dict` (no type parameters), `get_args(dict)` returns an empty tuple and the previous unconditional `get_args(stripped_type)[1]` raised IndexError. Guard with `args = get_args(stripped_type)` and only recurse into the value type when `len(args) >= 2`; otherwise return the data unchanged. Same fix applied to `_async_transform_recursive`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
Calling
transform()on a TypedDict whose field is annotated with a bare, unparameteriseddict(e.g.metadata: dict) raises anIndexError. The bug affects both the sync and async transform paths.Why it happens
_transform_recursiveand_async_transform_recursiveboth unconditionally accessget_args(stripped_type)[1]whenorigin == dict. For a baredict,get_args(dict)returns an empty tuple, so index1does not exist.Fix
Store
args = get_args(stripped_type)and only recurse withargs[1]whenlen(args) >= 2. When no type arguments are present the data is returned unchanged, which is the correct behaviour for an unparameterised dict.Test
Added
test_bare_dict_no_indexerrorintests/test_transform.py: passes{"metadata": {"key": "value"}}through a TypedDict with a baredictfield and asserts the result is returned unchanged without error. Runs in both sync and async variants.Fixes #3338