Repository navigation
chore(api): retain existing vault update support - #1161
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-java-internal#231 Castiron-Source-SHA: eaa64d9d49af176b37ad78537882b28b5a2d711e Castiron-Public-Base-SHA: 7149529
Contributor
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 105 mixed files remain; 0 existing customizations changed. Compared 105 existing customizations unchanged
65 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38070637876 --repo openai/openai-java \
--name castiron-custom-code-38070637876-1 --dir /tmp/castiron-custom-code-38070637876-1
git apply --stat /tmp/castiron-custom-code-38070637876-1/custom-code.patch
cat /tmp/castiron-custom-code-38070637876-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 7149529401d19e4747ea3b39faa776dd214a146f ec3fc1b41b8cb9f1819334196caf191c2058e044
python3 scripts/castiron/custom_code_report.py report \
--base 7149529401d19e4747ea3b39faa776dd214a146f \
--head ec3fc1b41b8cb9f1819334196caf191c2058e044 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-ec3fc1b41b8c
cat /tmp/castiron-custom-code-ec3fc1b41b8c/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
marked this pull request as ready for review
October 10, 2026 17:09
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
approved these changes
Oct 10, 2026
markstuart-oai
left a comment
markstuart-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed ec3fc1b41b8cb9f1819334196caf191c2058e044 against 7149529401d19e4747ea3b39faa776dd214a146f. The complete diff changes only .castiron.stats.yml. It updates the generation and checkpoint IDs, refreshes the public checkpoint field, and retains the specification, configuration, and generated-code hashes. There is no Java source or API change to review here.
I found no actionable issues. Hosted CI for this head was still running at review time. I did not run local tests or generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retains existing vault update and metadata filtering support.
Changes