chore(api): clarify Realtime modality array definitions - #1074
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 87 mixed files remain; 0 existing customizations changed. Compared 87 existing customizations unchanged
47 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35945223757 --repo openai/openai-java \
--name castiron-custom-code-35945223757-1 --dir /tmp/castiron-custom-code-35945223757-1
git apply --stat /tmp/castiron-custom-code-35945223757-1/custom-code.patch
cat /tmp/castiron-custom-code-35945223757-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 132f0959016b9c680abc273407dfe7d85ca27081 80f0332fef52ef171e4b78a950ffee4cf97e5746
python3 scripts/castiron/custom_code_report.py report \
--base 132f0959016b9c680abc273407dfe7d85ca27081 \
--head 80f0332fef52ef171e4b78a950ffee4cf97e5746 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-80f0332fef52
cat /tmp/castiron-custom-code-80f0332fef52/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete diff from 56ee772 to 9d87952. No blocking findings.
The only schema changes add type: array to RealtimeSession.modalities and RealtimeSessionCreateRequest.modalities. Existing item enums and optionality are preserved; no Java/Kotlin source, exported types, or method signatures changed.
Validation: parsed the full pinned base/head schemas and confirmed exactly those two key additions; the transformed-schema MD5 matches generation metadata; 20 independent positive/negative JSON Schema cases passed. The separate transcription-session schema is unchanged from the base. Exact-head hosted build/tests/lint, API and Jackson compatibility, Java 8/25 runtime compatibility, and Castiron baseline/budget checks passed. The separate OkTest run is still in progress at review time.
No live API calls or local Gradle suite were run.
|
Thanks @jbeckwith-oai for the independent Java review and schema checks. The reviewed head remains |
|
Thanks for the additional approval. The reviewed head remains |
9d87952 to
a5ab1bb
Compare
|
The merge conflict is repaired at The complete updated diff still contains only the two Realtime Validation: 112 public/transformed before-and-after schema checks pass. Local Gradle consumer/probe verification passes, including the existing concrete generic return types; compilation tasks were validated as up-to-date and the runtime fixture reran successfully for omission, empty/text/text+audio arrays, and stream options. The new public CI run, new OkTest run, and automated reviews are still pending. The older 236/236 OkTest pass is not being counted as a pass for this new head. No merge or release was performed. |
Castiron-Internal-PR: openai/openai-java-internal#146 Castiron-Source-SHA: 1a9678d8795890194d6c416277517e9477d15afd Castiron-Public-Base-SHA: 132f095
a5ab1bb to
80f0332
Compare
|
Thanks @dpiet-oai for reviewing the updated head. The merge conflict is resolved at The diff remains limited to the two Realtime array annotations and generation metadata. No Java/Kotlin source, public types, or method signatures differ from All 112 schema checks and local Java consumer checks pass. The new CI run and compatibility run are still running. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80f0332fef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Automated Release PR --- ## [4.69.1](openai/openai-java@v4.69.0...v4.69.1) (2026-09-24) ### Bug Fixes * buffer streamed tool arguments per tool ([openai#1070](openai#1070)) ([56ee772](openai@56ee772)) * **ci:** restrict legacy release guard to same-repository PRs ([openai#1058](openai#1058)) ([55de0fe](openai@55de0fe)) * complete asynchronous pagers when first-page handling fails ([openai#1050](openai#1050)) ([bd5e5d2](openai@bd5e5d2)) * disable compression for default WebSocket connections ([openai#1049](openai#1049)) ([8f7972a](openai@8f7972a)) * match header hashing to case-insensitive equality ([openai#1052](openai#1052)) ([82440c9](openai@82440c9)) * remove the unused asynchronous thread-owned lock helper ([openai#1072](openai#1072)) ([132f095](openai@132f095)) * retain response ownership while consuming a stream ([openai#1073](openai#1073)) ([697c9d0](openai@697c9d0)) ### Chores * **api:** clarify approximate web search location defaults ([openai#1071](openai#1071)) ([39a920a](openai@39a920a)) * **api:** clarify Realtime modality array definitions ([openai#1074](openai#1074)) ([66acb5d](openai@66acb5d)) * **api:** correct fine-tuning bounds and Realtime response reference ([openai#1068](openai#1068)) ([aa75cc5](openai@aa75cc5)) ### Documentation * clarify collaborator-only pull request policy ([openai#1066](openai#1066)) ([c9f222f](openai@c9f222f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
3 participants
Summary
Clarifies retained Realtime modality arrays in the API reference without changing SDK types or method signatures.
Changes