[faster-connectors] (1/4) Extract apps cache logic into ConnectorRuntimeManager - #31471
[faster-connectors] (1/4) Extract apps cache logic into ConnectorRuntimeManager#31471mzeng-openai wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f4775b492
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95f76cd3e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What
ConnectorRuntimeManager,ConnectorRuntimeContext, and an immutable tools-plus-refresh-time snapshot.app/listcallers and startup behavior do not change in this slice.Why
This is stack PR 1 of 4 for the connector runtime state refactor. It establishes one owner for committed connector runtime state before later PRs add explicit refresh serialization, request-stable consumption, and the v2
app/installedAPI.The snapshot intentionally contains runtime facts only: the raw
/ps/mcp tools/listToolInfoset andrefreshed_at. Connector directory metadata remains owned byapp/read/ConnectorMetadataStore.Compatibility and impact
app/listbehavior change._meta.installedAppsdependency.{ "schema_version": 4, "tools": [...] }, so existing caches remain readable.Checks
just test -p codex-mcp(112 passed)just fmt