fix: honor the requested output format when rerunning a scan - #203
Open
mariohercules wants to merge 2 commits into
Open
fix: honor the requested output format when rerunning a scan#203mariohercules wants to merge 2 commits into
mariohercules wants to merge 2 commits into
Conversation
`scans rerun` called `runScan` without forwarding the requested output format, so it always used the interactive default. With `--json` or `--format jsonl` it could block on the credential-selection prompt that `scan` suppresses in the same situation, and it accepted `--format md`, which `scan` rejects as unsupported for scan results. Forward the format from the rerun command so both behaviors match `scan`. Fixes openai#39
mariohercules
force-pushed
the
fix/rerun-honors-output-format
branch
from
August 1, 2026 23:42
fe85079 to
a88e425
Compare
Collaborator
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Problem
scans reruncalledrunScanwithout forwarding the requested output format, so it always took theinteractive = truedefault.scancomputes it from the format:interactivegates the credential-selection prompt and the TTY progress rendering, soscans rerun <id> --jsoncould block on a prompt thatscan --jsonsuppresses in exactly the same situation. In an automated context holding a pty, the command waits for input that never arrives.The same missing plumbing meant
scans rerun --format mdwas accepted, whilescan --format mdis rejected up front as unsupported for scan results — both commands produce the same scan payload.Change
Forward the format from the rerun command so both behaviors match
scan.Tests
Two tests, both verified to fail without the change:
tests-ts/cli-authentication.test.ts—scans rerun --jsonand--format jsonlnever prompt, mirroring the existing "never prompts during automation" guarantee that covered onlyscan.tests-ts/cli-workbench.test.ts—scans rerun --format mdexits 2 without starting a scan.Full suite on this branch: 719 pass, 5 skip, 0 fail.
pnpm run typesandpnpm run formatare clean.