Skip to content

remove from diagnostic section#33

Merged
maryliag merged 1 commit into
open-telemetry:mainfrom
maryliag:cap-diag
Jul 2, 2026
Merged

remove from diagnostic section#33
maryliag merged 1 commit into
open-telemetry:mainfrom
maryliag:cap-diag

Conversation

@maryliag

@maryliag maryliag commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Prior PR added a cap to the tables, but I forgot to add the same cap to the diagnostic section.
Also printed the size of the body, to help with debug

Copilot AI review requested due to automatic review settings July 2, 2026 19:26
@maryliag maryliag requested review from a team and trask as code owners July 2, 2026 19:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the max_rows_per_section cap—previously applied only to the "Waiting on …" tables and the drafts table—to also cover the Diagnostics section, preventing the dashboard issue body from exceeding GitHub's 65,536-character limit in very large repositories.

Changes:

  • Refactored render_diagnostics_section to accept max_rows_per_section, pre-filter PRs with content into a list, apply _limit_rows, and append a _truncation_note when rows are dropped.
  • Threaded max_rows_per_section through the single call site in render_pr_tables.
  • Enhanced the dashboard-write log line to report the rendered character count against the 65,536 limit, and updated the README to reflect that the cap now includes the Diagnostics block.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/scripts/pull-request-dashboard/render.py Applies the row cap and truncation note to the diagnostics section and passes the cap from the caller.
.github/scripts/pull-request-dashboard/dashboard.py Adds rendered character count to the write log for easier size diagnostics.
pull-request-dashboard/README.md Documents that the cap now applies to the Diagnostics block.

The refactored render_diagnostics_section preserves the original filtering behavior (PRs with classifications or errors), correctly returns early on empty content, and applies truncation consistently with render_draft_pr_section and the route tables via the shared _limit_rows/_truncation_note helpers. The README section names match the code, and there are no test files for these scripts, so no test-coverage feedback applies. No issues found.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@maryliag maryliag merged commit f8ecb75 into open-telemetry:main Jul 2, 2026
5 checks passed
@maryliag maryliag deleted the cap-diag branch July 2, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants