chore(metrics): add benchmark for metrics#2106
chore(metrics): add benchmark for metrics#2106xuan-cao-swi wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
xuan-cao-swi
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
xuan-cao-swi
changed the title
| spec.add_dependency 'opentelemetry-api', '~> 1.0' | ||
|
|
||
| spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0' | ||
| spec.add_development_dependency 'benchmark-ips', '~> 2.14.0' |
There was a problem hiding this comment.
Should this not be added to the gemfile instead?
There was a problem hiding this comment.
I am ok with either put here or in gemfile
There was a problem hiding this comment.
Why would it move to the Gemfile?
There was a problem hiding this comment.
Because currently we are needing to disable the rubocop cop so it doesn't fail, it would increase consistency with contrib & renovate natively updates it etc.
There was a problem hiding this comment.
If we want to change the way we handle the dev dependencies in this repository, what do you think about moving them all at once in a different PR?
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
This is great, thank you @xuan-cao-swi! Love the Rake task too, @robbkidd!
| | Counter | SimpleFixedSize | 126,669.7 i/s | 7.89 μs/i | **Fastest** | | ||
| | Histogram | SimpleFixedSize | 118,602.8 i/s | 8.43 μs/i | 1.07x slower | | ||
| | Histogram | AlignedHistogramBucket | 113,535.5 i/s | 8.81 μs/i | 1.12x slower | | ||
| | Counter | Noop | 25,391.0 i/s | 39.38 μs/i | 4.99x slower | |
There was a problem hiding this comment.
This metrics needs to be updated once the fix for noop exemplar is merged and released
4 participants
Description
Inspired by api/benchmarks, and use native
benchmark-ipsinstead ofbenchmark-ipsa