chore: remove kramdown#2097
Open
thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Conversation
thompson-tomo
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
Contributor
There was a problem hiding this comment.
The kramdown removal looks good to me.
Also The docs appear to not be published as link points to a url which lacks a link to sem-conv.
I can find the docs on rubydoc: https://rubydoc.info/gems/opentelemetry-semantic_conventions
Should the link that you're referring to be somewhere on this page? https://open-telemetry.github.io/opentelemetry-ruby/
kaylareopelle
approved these changes
May 5, 2026
Contributor
Author
|
@kaylareopelle according to the gemspec the documentation is at https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-semantic_conventions/v#{OpenTelemetry::SemanticConventions::VERSION which redirects to https://open-telemetry.github.io/opentelemetry-ruby/ and semantic conventions is not listed. Let's update the links seperately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove kramdown from sem conv gem which appears not to be used.
Also The docs appear to not be published as link points to a url which lacks a link to sem-conv.