Randomize per-thread recording order to avoid concurrency hotspots#8550
Merged
jack-berg merged 3 commits intoJul 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8550 +/- ##
============================================
- Coverage 90.96% 90.96% -0.01%
+ Complexity 10206 10205 -1
============================================
Files 1013 1013
Lines 27166 27166
Branches 3182 3182
============================================
- Hits 24712 24711 -1
Misses 1730 1730
- Partials 724 725 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discussing #8527 in the last java SIG, @trask brought up the point that perhaps the apparent 37% reduction in performance for cardinality=128,temporality=cumulative,instrument=COUNTER_SUM case while the same case with cardinality=1 case improves is not expected, and might be caused test harness itself.
Indeed this turned out to be the case. The multi-thread cases all record to the same set of series in the same order. To mitigate, this PR creates a randomized record order for each distinct series. Recordings will occasionally collide and that's expected and desired, but they won't always collide as a structural side affect.