Deprecate Zipkin exporter#7974
Conversation
d38d30b to
6bc46a9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7974 +/- ##
=========================================
Coverage 90.16% 90.16%
Complexity 7478 7478
=========================================
Files 836 836
Lines 22550 22550
Branches 2224 2224
=========================================
Hits 20333 20333
Misses 1515 1515
Partials 702 702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think we should just mark the zipkin exporter as deprecated for now and come back to the problem of removing shared internal code later. There are a couple of things we could do with the shared internal code which don't involve copying into the zipkin exporter:
|
5c1ee8b to
ba8c91c
Compare
|
@jack-berg I've updated the PR to remove copying to internal code. |
...pkin/src/main/java/io/opentelemetry/exporter/zipkin/internal/ZipkinSpanExporterProvider.java
Show resolved
Hide resolved
|
Thank you for your contribution @michaeljohnalbers! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Deprecates the Zipkin exporter and removes all dependencies on internal classes. This involved copying several classes into a sub-package of the Zipkin exporter package. There is a README.md in this package with a short explanation. Several test classes had to be updated to handle the deprecation.
First part of implementing #7863