[TEST] Add Windows max macro regression test for OTLP public headers#3865
[TEST] Add Windows max macro regression test for OTLP public headers#3865ThomsonTan wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 225 225
Lines 7170 7170
=======================================
Hits 6452 6452
Misses 718 718 🚀 New features to boost your workflow:
|
|
What this new test will do, is prevent similar bugs to be introduced again in It will not prevent another similar bug to appear in another header file. Suggestion: implement a new CI check script, similar to A script running |
Ok. Close this PR for now as it only validates regression from very specific scenario. Will think on making it general like define it as global before including the API headers. |
Follow up for the comment #3861 (comment)
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes