[chore] [cmd/schemagen] Ensure schemas are up-to-date with Go structs #45436
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent config schemas are up-to-date with corresponding Go structs
dmitryax
reviewed
Jan 15, 2026
| ./cmd/schemagen/run_schemagen_dir.sh ./connector | ||
|
|
||
| .PHONY: checkschema | ||
| checkschema: |
Member
There was a problem hiding this comment.
I don't think we need a separate target for this. Let's stick to the existing pattern https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/build-and-test.yml#L139-L172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
checkschemascript that allows verifying whether all component config schemas are up-to-date with corresponding Go structs.Script generates schemas for all components and uses
git diffto find if there are any changes.Testing
Manual testing:
make checkschema-> should finish successfullyreceiver/icmpcheckreceiverGo config structmake checkschema-> should finish with error(For faster execution you can limit schema generation only to receivers by commenting out other directories in
generate-schematask)