[pprofreceiver] add file scraper to read pprof files #45411
Conversation
Signed-off-by: Florian Lehner <[email protected]>
florianl
requested review from
a team,
MovieStoreGuy and
atoulme
as code owners
| go.opentelemetry.io/collector/receiver/xreceiver v0.143.1-0.20260109195331-fbd5d3f9faae | ||
| go.opentelemetry.io/collector/scraper v0.143.0 | ||
| go.opentelemetry.io/collector/scraper/scraperhelper v0.143.1-0.20260113235037-cac5574b46c0 | ||
| go.opentelemetry.io/collector/scraper/scraperhelper/xscraperhelper v0.0.0-20260113235037-cac5574b46c0 |
There was a problem hiding this comment.
xscraperhelper was just merged and is not part yet of a released version. Therefore latest current commit on main was used.
There was a problem hiding this comment.
You'll want to use the same core version as other packages (v0.143.1-0.20260109195331-fbd5d3f9faae) for these few ones
There was a problem hiding this comment.
I guess, I will wait with an update for next week when there is a new release. With the new release I don't require to touch other packages and increase complexity of this change.
Signed-off-by: Florian Lehner <[email protected]>
| } | ||
|
|
||
| func (s *pprofScraper) scrape(_ context.Context) (pprofile.Profiles, error) { | ||
| matches, err := doublestar.FilepathGlob(s.config.Include) |
There was a problem hiding this comment.
please add a test with a simple pprof test file so we can ensure the code can read and interpret to pprofile. The assertion on the pprofile data can be as simple as checking one profile is present - we're just interested in finding if this method runs ok.
| scraperhelper.ControllerConfig `mapstructure:",squash"` | ||
|
|
||
| // Include is the glob pattern for pprof files to scrape. | ||
| Include string `mapstructure:"include"` |
There was a problem hiding this comment.
Please add to README config?
|
|
||
| // Config defines the configuration for the pprof receiver. | ||
| type Config struct { | ||
| confighttp.ClientConfig `mapstructure:",squash"` |
There was a problem hiding this comment.
I still want to be able to open a port and receive pprof profile data over HTTP - see #44385
atoulme
changed the title
4 participants
Description
Follow up to #44357
Implement the functionality of transforming pprof to OTel Profiles
FYI: @open-telemetry/profiling-approvers
Link to tracking issue
Fixes
Testing
Documentation