[exporter/loadbalancing] fix Kubernetes resolver initialization #45380
+256
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
reviewed
Jan 14, 2026
Contributor
iblancasa
left a comment
iblancasa
left a comment
There was a problem hiding this comment.
I think we should test error propagation from start(): no test verifies that errors from newInClusterClient() are properly returned.
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
loadbalancing-config-validate
branch
from
33d8595 to
e39b52c
Compare
Contributor
Author
Added additional testing |
Signed-off-by: odubajDT <[email protected]>
iblancasa
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Kubernetes resolver initialization to allow exporter creation outside k8s cluster by deferring client creation to start time
Added some additional testing as well
Link to tracking issue
Fixes #42293