Skip to content

fix: use move instead of copy for span in groupbyattrs processor #45359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varkey98 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

fix: use move instead of copy for span in groupbyattrs processor #45359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11ac73
use move instead of copy
varkey98 Jan 12, 2026
82b4970
update to move all signals
varkey98 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions processor/groupbyattrsprocessor/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (gap *groupByAttrsProcessor) processTraces(ctx context.Context, td ptrace.T
// and keep them in the grouping entry
groupedResourceSpans := tg.findOrCreateResourceSpans(rs.Resource(), requiredAttributes)
sp := matchingScopeSpans(groupedResourceSpans, ils.Scope()).Spans().AppendEmpty()
span.CopyTo(sp)
span.MoveTo(sp)
}
}
}
Expand Down Expand Up @@ -87,7 +87,7 @@ func (gap *groupByAttrsProcessor) processLogs(ctx context.Context, ld plog.Logs)
// and keep them in the grouping entry
groupedResourceLogs := lg.findOrCreateResourceLogs(ls.Resource(), requiredAttributes)
lr := matchingScopeLogs(groupedResourceLogs, sl.Scope()).LogRecords().AppendEmpty()
log.CopyTo(lr)
log.MoveTo(lr)
}
}
}
Expand Down Expand Up @@ -117,35 +117,35 @@ func (gap *groupByAttrsProcessor) processMetrics(ctx context.Context, md pmetric
for pointIndex := 0; pointIndex < metric.Gauge().DataPoints().Len(); pointIndex++ {
dataPoint := metric.Gauge().DataPoints().At(pointIndex)
groupedMetric := gap.getGroupedMetricsFromAttributes(ctx, mg, rm, ilm, metric, dataPoint.Attributes())
dataPoint.CopyTo(groupedMetric.Gauge().DataPoints().AppendEmpty())
dataPoint.MoveTo(groupedMetric.Gauge().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeSum:
for pointIndex := 0; pointIndex < metric.Sum().DataPoints().Len(); pointIndex++ {
dataPoint := metric.Sum().DataPoints().At(pointIndex)
groupedMetric := gap.getGroupedMetricsFromAttributes(ctx, mg, rm, ilm, metric, dataPoint.Attributes())
dataPoint.CopyTo(groupedMetric.Sum().DataPoints().AppendEmpty())
dataPoint.MoveTo(groupedMetric.Sum().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeSummary:
for pointIndex := 0; pointIndex < metric.Summary().DataPoints().Len(); pointIndex++ {
dataPoint := metric.Summary().DataPoints().At(pointIndex)
groupedMetric := gap.getGroupedMetricsFromAttributes(ctx, mg, rm, ilm, metric, dataPoint.Attributes())
dataPoint.CopyTo(groupedMetric.Summary().DataPoints().AppendEmpty())
dataPoint.MoveTo(groupedMetric.Summary().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeHistogram:
for pointIndex := 0; pointIndex < metric.Histogram().DataPoints().Len(); pointIndex++ {
dataPoint := metric.Histogram().DataPoints().At(pointIndex)
groupedMetric := gap.getGroupedMetricsFromAttributes(ctx, mg, rm, ilm, metric, dataPoint.Attributes())
dataPoint.CopyTo(groupedMetric.Histogram().DataPoints().AppendEmpty())
dataPoint.MoveTo(groupedMetric.Histogram().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeExponentialHistogram:
for pointIndex := 0; pointIndex < metric.ExponentialHistogram().DataPoints().Len(); pointIndex++ {
dataPoint := metric.ExponentialHistogram().DataPoints().At(pointIndex)
groupedMetric := gap.getGroupedMetricsFromAttributes(ctx, mg, rm, ilm, metric, dataPoint.Attributes())
dataPoint.CopyTo(groupedMetric.ExponentialHistogram().DataPoints().AppendEmpty())
dataPoint.MoveTo(groupedMetric.ExponentialHistogram().DataPoints().AppendEmpty())
}

case pmetric.MetricTypeEmpty:
Expand Down
Loading