Skip to content

fix calculation of γ and remove a false comment in the Wikipedia tutorial#1812

Merged
slayoo merged 2 commits intomainfrom
slayoo-patch-25
Mar 24, 2026
Merged

fix calculation of γ and remove a false comment in the Wikipedia tutorial#1812
slayoo merged 2 commits intomainfrom
slayoo-patch-25

Conversation

@slayoo
Copy link
Copy Markdown
Member

@slayoo slayoo commented Feb 27, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.85%. Comparing base (d1c9c73) to head (dd02043).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1812   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files         415      415           
  Lines       10558    10558           
=======================================
  Hits         9170     9170           
  Misses       1388     1388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Removed unnecessary comment from the simulate function.
@slayoo slayoo changed the title fix calculation of γ in the Wikipedia tutorial fix calculation of γ and remove a false comment in the Wikipedia tutorial Feb 28, 2026
@slayoo
Copy link
Copy Markdown
Member Author

slayoo commented Mar 24, 2026

well, it's tricky to test this one as the settings from the Golovin test case used in Shima et al. paper do not actually depend on the path which is being fixed here... let's just merge

@slayoo slayoo merged commit b7dc216 into main Mar 24, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant