Skip to content

Production hardening for PR183 strategy deployment#209

Open
liobrasil wants to merge 5 commits intonialexsan/fyv-v2-strategy-deploymentfrom
lionel/pr183-production-hardening
Open

Production hardening for PR183 strategy deployment#209
liobrasil wants to merge 5 commits intonialexsan/fyv-v2-strategy-deploymentfrom
lionel/pr183-production-hardening

Conversation

@liobrasil
Copy link
Contributor

@liobrasil liobrasil commented Mar 11, 2026

Why this PR exists

PR #183 is still in draft, and the review of #182/#183 surfaced a few remaining issues that should be fixed before promoting that work toward production:

  • syWFLOWvStrategy.closePosition() can fail when FlowALP returns vaults in non-deterministic order
  • the mainnet setup script does not actually wire the v2 syWFLOWvStrategy into production deployment
  • FUSDEVStrategy leaks per-vault runtime swapper state on close/burn
  • the FUSDEV close path still tolerates unexpected returned vaults too loosely, and the comments do not fully match the real behavior

This PR is the production-hardening follow-up for those remaining issues.

What this PR fixes

  • fix unordered close-position results in syWFLOWvStrategy
  • add the missing v2 syWFLOWvStrategy mainnet setup and composer registration
  • clean up leaked FUSDEV per-vault swapper state during burnCallback()
  • harden FUSDEV close-position return handling and align the code comments with the actual close-path behavior
  • tighten the syWFLOWv setup comments after rebasing onto the latest target branch

Validation

  • flow test --fork=mainnet cadence/tests/FlowYieldVaultsStrategiesV2_FUSDEV_test.cdc
  • flow test --fork=mainnet cadence/tests/FlowYieldVaultsStrategiesV2_syWFLOWv_test.cdc
  • bash -n local/setup_mainnet.sh

@liobrasil liobrasil requested a review from a team as a code owner March 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant