Production hardening for PR183 strategy deployment#209
Open
liobrasil wants to merge 5 commits intonialexsan/fyv-v2-strategy-deploymentfrom
Open
Production hardening for PR183 strategy deployment#209liobrasil wants to merge 5 commits intonialexsan/fyv-v2-strategy-deploymentfrom
liobrasil wants to merge 5 commits intonialexsan/fyv-v2-strategy-deploymentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
PR #183 is still in draft, and the review of #182/#183 surfaced a few remaining issues that should be fixed before promoting that work toward production:
syWFLOWvStrategy.closePosition()can fail when FlowALP returns vaults in non-deterministic ordersyWFLOWvStrategyinto production deploymentFUSDEVStrategyleaks per-vault runtime swapper state on close/burnThis PR is the production-hardening follow-up for those remaining issues.
What this PR fixes
syWFLOWvStrategysyWFLOWvStrategymainnet setup and composer registrationburnCallback()syWFLOWvsetup comments after rebasing onto the latest target branchValidation
flow test --fork=mainnet cadence/tests/FlowYieldVaultsStrategiesV2_FUSDEV_test.cdcflow test --fork=mainnet cadence/tests/FlowYieldVaultsStrategiesV2_syWFLOWv_test.cdcbash -n local/setup_mainnet.sh