Make manifest URLs use oclif template config#1266
Open
pimterry wants to merge 1 commit intooclif:mainfrom
Open
Make manifest URLs use oclif template config#1266pimterry wants to merge 1 commit intooclif:mainfrom
pimterry wants to merge 1 commit intooclif:mainfrom
Conversation
Debatable whether this is a feature or a fix, since it used to work, but it's been such a long time since it did that it's effectively totally new.
pimterry
force-pushed
the
template-urls
branch
from
7963317 to
bd187c7
Compare
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards fixing oclif/oclif#828.
Actually releasing this might require a major bump. It only applies if the user has templates set in oclif -> update -> s3 -> templates, but if anybody has some of these leftover from older versions of Oclif when they were supported, and then updates this package, they will unexpectedly start fetching from a new location which will probably break their update mechanism entirely.
I would have assumed that was unlikely, but it turns out this even applies to the tests in this repo - they still have a templates section even though it hasn't been functional since Oclif v1, and so changing this code breaks all the nock mocking in the tests because the URL changes.
I'll open a parallel PR to update the publish-side code in just a minute as well.