-
Notifications
You must be signed in to change notification settings - Fork 43.8k
Optional snacks #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Optional snacks #1632
Conversation
|
nicely done! perhaps some commits could be squashed, these two together: add vim.g toggle to disable telescope and these two as well: add snacks(picker) as an optional plugin which would end up in 3 commits, easier to follow changes. |
|
Ah sure, I was thinking commits will be squashed on merge anyway, so I was a little messy. I'll fix that |
|
This looks great, but as I said in #1481 (comment), I do think it would be better to just have one picker. Though, I think it would be beneficial to have the autocmds defined in the plugin, even if in the end only one of the pickers would be chosen, because it would be easier to switch to the other 😄 |
|
I should split this into two prs then One for the telescope change and one for snacks, so we can better decide on that |
add some comments to snacks picker to get it inline with telescope config
| -- picker like this one here more easily when the keymaps are defined in the plugin itself. | ||
| -- It sets up buffer-local keymaps, autocommands, and other LSP-related settings | ||
| -- whenever an LSP client attaches to a buffer. | ||
| config = function() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, should this not be init instead of config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, should this not be
initinstead ofconfig?
This used to be together with this:
I separated them into two prs. This one will likely not be merged, at least according to what I feel is the current consensus regarding kickstart.
If you ever want to replace telescope, you can always take this once the smaller change is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szechp, i did replace telescope with snacks, but it looks like using config as is will override any opts being set.. only thing that worked for me was to replace it with init
|
This is a nice PR - i'm not sure what to do with it though. Thinking most likely would be to close because I don't want to put a ton of alternatives for every single plugin. Honestly (even tho obviously i love telescope since it's my baby haha) i am thinking about putting one of the other plugins here because for me telescope is basically finished software (does everything i like) but I know other fuzzy finders are pushing new things forward |
|
That's ok :) I guess everyone that's starts with this repo should be able to exchange their picker. But It would be nice to get the telescope calls outside of the plugin Lua back inside the file. I'll do another Mr with that |
|
Ya, I think I merged your prev request that moved all the telescope config into the telescope plugin. So it should be very easy to disable now and switch to new picker for people |
|
Ah I already did that, lol |
|
haha well it was only six months ago lololol |
as discussed here: #1481 i have implemented snacks picker as an optional replacement for telescope. I hope that we can use this implementation to add more optional plugins, so we don't waste time on deciding if we want whatever new shiny plugin needs to be added or not.
Now we can provide a stable base, but we can also add optional plugins and users can decide themselves.
(thanks to @oriori1703, i just copied his snacks config from the other mr)