Skip to content

fix: outdated dependencies icon not shown - #3099

Merged
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:fix-verkit-prerelease-changes
Jul 29, 2026
Merged

fix: outdated dependencies icon not shown#3099
gameroman merged 1 commit into
npmx-dev:mainfrom
gameroman:fix-verkit-prerelease-changes

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

Closes #3098

🧭 Context

This is related to breaking changes in verkit@0.2.0

Missed it when doing #3093

📚 Description

Fixes outdated dependencies icon not being shown

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 29, 2026 3:58pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 29, 2026 3:58pm
npmx-lunaria Ignored Ignored Jul 29, 2026 3:58pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c9fbe3fb-f482-4e94-b631-2fd97173667a

📥 Commits

Reviewing files that changed from the base of the PR and between 939b59f and e4fa205.

📒 Files selected for processing (2)
  • app/composables/npm/useOutdatedDependencies.ts
  • server/utils/npm.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved prerelease version filtering when checking for outdated dependencies.
    • Dependency recommendations now more reliably exclude prerelease versions unless explicitly permitted by the version constraint.

Walkthrough

Both outdated dependency resolution paths now use getPrerelease(v)?.length to exclude prerelease versions when the constraint does not permit prereleases.

Changes

Prerelease filtering

Layer / File(s) Summary
Tighten prerelease candidate filtering
server/utils/npm.ts, app/composables/npm/useOutdatedDependencies.ts
Prerelease exclusion now checks the parsed prerelease component’s length before selecting candidate versions.

Possibly related PRs

  • npmx-dev/npmx.dev#3061: Introduced the related semver-to-verkit prerelease filtering and satisfying-version selection logic.

Suggested reviewers: sxzz

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: restoring the outdated dependencies icon.
Description check ✅ Passed The description is directly related to the bug fix and mentions the affected dependency change.
Linked Issues check ✅ Passed The changes address the reported prerelease filtering regression that likely hid the outdated dependencies icon on main.
Out of Scope Changes check ✅ Passed The diff is narrowly focused on prerelease filtering and contains no obvious unrelated changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
server/utils/npm.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@graphieros graphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌿

@gameroman
gameroman added this pull request to the merge queue Jul 29, 2026
Merged via the queue into npmx-dev:main with commit d0dafcf Jul 29, 2026
25 checks passed
@gameroman
gameroman deleted the fix-verkit-prerelease-changes branch July 29, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated dependencies icon is not shown on main

2 participants