Skip to content

feat: added feature to copy version number by hovering on the version #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PreethiPantangi wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: added feature to copy version number by hovering on the version #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ed5b85
Added feature to copy version number by hovering on the version
PreethiPantangi Apr 30, 2026
deb30ac
Added copy_number to schema and incorporate review changes in Header.vue
PreethiPantangi Apr 30, 2026
6b32d0f
Deleted unnecessary files
PreethiPantangi Apr 30, 2026
698c6d9
Added logic to hide the copy button when choosing a different version
PreethiPantangi May 2, 2026
57d5fd8
Merge branch 'main' into main
PreethiPantangi May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/components/CopyToClipboardButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const props = defineProps<{
ariaLabelCopy?: string
ariaLabelCopied?: string
buttonAttrs?: HTMLAttributes
hideCopyText?: boolean
}>()

const buttonCopyText = computed(() => props.copyText || $t('common.copy'))
Expand All @@ -32,6 +33,7 @@ function handleClick() {
<div class="group relative" v-bind="$attrs">
<slot />
<button
v-if="!hideCopyText"
type="button"
@click="handleClick"
class="absolute z-20 inset-is-0 top-full inline-flex items-center gap-1 px-2 py-1 rounded border text-xs font-mono whitespace-nowrap transition-all duration-150 opacity-0 -translate-y-1 pointer-events-none group-hover:opacity-100 group-hover:translate-y-0 group-hover:pointer-events-auto focus-visible:opacity-100 focus-visible:translate-y-0 focus-visible:pointer-events-auto"
Expand Down
72 changes: 59 additions & 13 deletions app/components/Package/Header.vue
View file
Open in desktop
Copy link
Copy Markdown
Member

@knowler knowler May 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall, the previous layout of package pages had the version number next to the package name which was a better candidate for a convenience like this. Now, with the version being a part of the version selector — a component that has significant issues on its own — this seems like a bit too much is going on. If we want this functionality, I think a dedicated button next to the version number would be better, as it avoids two popover interactions for the same element and the button on hover could be inferred as a tooltip for what the version selector does. That or we should find somewhere else to do this.

Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,21 @@ const packageHeaderHeight = usePackageHeaderHeight()
const header = useTemplateRef('header')
const isHeaderPinned = shallowRef(false)
const { height: headerHeight } = useElementBounding(header)
const versionSelectorRef = useTemplateRef('versionSelectorRef')
const versionSelectorOpen = computed(() => versionSelectorRef.value?.isOpen ?? false)
const shouldHideCopyText = ref(false)
let hideTextTimeout: ReturnType<typeof setTimeout> | null = null

watch(versionSelectorOpen, isOpen => {
if (isOpen) {
shouldHideCopyText.value = true
if (hideTextTimeout) clearTimeout(hideTextTimeout)
} else {
hideTextTimeout = setTimeout(() => {
shouldHideCopyText.value = false
}, 300)
}
})
Comment on lines +27 to +38
Copy link
Copy Markdown
Contributor

@gameroman gameroman May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the timeout do here?

Copy link
Copy Markdown
Author

@PreethiPantangi PreethiPantangi May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we close the version selector, there's a short delay before the copy text comes back, to prevent UI flickering if someone opens and closes the selector quickly (like an accidental click). 300ms keeps it feeling smooth. The 300ms was added to keep it smooth.

Copy link
Copy Markdown
Contributor

@gameroman gameroman May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a little bit weird/unnatural with the delay, as if it's broken

I'm thinking,

Either the delay could be decreased

Or, hide the Copy version number button completely, so even when the version picker is closed, it is not shown until you move your mouse away from it and hover again


function isStickyPinned(el: HTMLElement | null): boolean {
if (!el) return false
Expand Down Expand Up @@ -61,6 +76,7 @@ const { y: scrollY } = useScroll(window)
const showScrollToTop = computed(() => scrollY.value > SCROLL_TO_TOP_THRESHOLD)

const packageName = computed(() => props.pkg?.name ?? '')
const resolvedVersionDisplay = computed(() => props.resolvedVersion ?? '')
const fundingUrl = computed(() => {
let funding = props.displayVersion?.funding
if (Array.isArray(funding)) funding = funding[0]
Expand All @@ -75,6 +91,11 @@ const { copied: copiedPkgName, copy: copyPkgName } = useClipboard({
copiedDuring: 2000,
})

const { copied: copiedPkgVersion, copy: copyPkgVersion } = useClipboard({
source: resolvedVersionDisplay,
copiedDuring: 2000,
})

function hasProvenance(version: PackumentVersion | null): boolean {
if (!version?.dist) return false
return !!(version.dist as { attestations?: unknown }).attestations
Expand All @@ -86,8 +107,10 @@ useCommandPaletteContextCommands(
computed((): CommandPaletteContextCommandInput[] => {
if (!packageName.value) return []

const commands: CommandPaletteContextCommandInput[] = [
{
const commands: CommandPaletteContextCommandInput[] = []

if (packageName.value) {
commands.push({
id: 'package-copy-name',
group: 'package',
label: $t('package.copy_name'),
Expand All @@ -97,8 +120,22 @@ useCommandPaletteContextCommands(
copyPkgName()
announce($t('command_palette.announcements.copied_to_clipboard'))
},
},
]
})
}
Comment on lines 110 to +124
Copy link
Copy Markdown
Contributor

@gameroman gameroman May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do it like this

    const commands: CommandPaletteContextCommandInput[] = [
      {
        id: 'package-copy-name',
        group: 'package',
        label: $t('package.copy_name'),
        keywords: [packageName.value],
        iconClass: 'i-lucide:copy',
        action: () => {
          copyPkgName()
          announce($t('command_palette.announcements.copied_to_clipboard'))
        },
      }
    ]


if (props.resolvedVersion) {
commands.push({
id: 'package-copy-version',
group: 'package',
label: $t('package.versions.copy_version'),
keywords: [props.resolvedVersion ?? ''],
iconClass: 'i-lucide:copy',
action: () => {
copyPkgVersion()
announce($t('command_palette.announcements.copied_to_clipboard'))
},
})
}

if (fundingUrl.value) {
commands.push({
Expand Down Expand Up @@ -287,16 +324,25 @@ useShortcuts({
<span class="i-lucide:cable rtl-flip min-w-3 w-3 h-3 mx-1" aria-hidden="true" />
</TooltipApp>
</template>
<!-- Version selector -->
<VersionSelector
<CopyToClipboardButton
:copied="copiedPkgVersion"
v-if="resolvedVersion && pkg?.versions && pkg?.['dist-tags']"
:package-name="packageName"
:current-version="resolvedVersion"
:versions="pkg.versions"
:dist-tags="pkg['dist-tags']"
:url-pattern="versionUrlPattern"
position-class="max-md:inset-is-0 md:inset-ie-0"
/>
:copy-text="$t('package.versions.copy_version')"
:hide-copy-text="shouldHideCopyText"
class="inline-flex items-center min-w-0"
@click="copyPkgVersion()"
>
<!-- Version selector -->
<VersionSelector
ref="versionSelectorRef"
:package-name="packageName"
:current-version="resolvedVersion"
:versions="pkg.versions"
:dist-tags="pkg['dist-tags']"
:url-pattern="versionUrlPattern"
position-class="max-md:inset-is-0 md:inset-ie-0"
/>
</CopyToClipboardButton>
</div>
</div>
<!-- Docs + Code — inline on desktop, floating bottom bar on mobile -->
Expand Down
5 changes: 5 additions & 0 deletions app/components/VersionSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,11 @@ watch(
}
},
)

// Expose isOpen state to parent components
defineExpose({
isOpen,
})
</script>

<template>
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,8 @@
},
"page_title": "Version History",
"current_tags": "Current Tags",
"no_match_filter": "No versions match {filter}"
"no_match_filter": "No versions match {filter}",
"copy_version": "Copy version number"
},
"timeline": {
"load_more": "Load more",
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,6 +1716,9 @@
},
"no_match_filter": {
"type": "string"
},
"copy_version": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
Loading