fix(arborist): preserve bundleDependencies: true when saving package.json - #9958
Open
36degrees wants to merge 2 commits into
Open
fix(arborist): preserve bundleDependencies: true when saving package.json#995836degrees wants to merge 2 commits into
bundleDependencies: true when saving package.json#995836degrees wants to merge 2 commits into
Conversation
36degrees
force-pushed
the
preserve-bundle-dependencies-true
branch
from
September 9, 2026 10:18
8eb0f93 to
14f8e40
Compare
36degrees
changed the title
bundleDependencies: true when saving package.jsonbundleDependencies: true when saving package.json
This 'fails' as the snapshot shows that `bundleDependencies` in package.json is normalised to an array of dependencies.
If the original package.json used `bundleDependencies: true`, preserve that boolean value when updating package.json, rather than overwriting it with the normalized list of packages.
36degrees
force-pushed
the
preserve-bundle-dependencies-true
branch
from
September 9, 2026 10:20
14f8e40 to
3640f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the original package.json used
bundleDependencies: true, preserve that boolean value when updatingpackage.json, rather than overwriting it with the normalized list of packages.Note
This is my first time contributing to the codebase – please review with this in mind. I had some help from CoPilot understanding the codebase and where the change should be made, but the code changes are my own.
References
Fixes #6498