fix: prune optional peer dependencies that are no longer explicitly depended on#8449
Open
G-Rath wants to merge 5 commits intonpm:release/v10from
Open
fix: prune optional peer dependencies that are no longer explicitly depended on#8449G-Rath wants to merge 5 commits intonpm:release/v10from
G-Rath wants to merge 5 commits intonpm:release/v10from
Conversation
G-Rath
commented
Jul 21, 2025
| const needPrune = metaFromDisk && (mutateTree || flagsSuspect) | ||
| if (this.#prune && needPrune) { | ||
| this.#idealTreePrune() | ||
| for (const node of this.idealTree.inventory.values()) { |
Contributor
Author
There was a problem hiding this comment.
note: I snuck #8430 in because I feel otherwise technically I should apply the fix to this loop too as they're the same, and technically this loop has a performance cost so removing it is a little nicer
G-Rath
force-pushed
the
v10-backport
branch
2 times, most recently
from
2a6d010 to
b8e5662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Backports #8430 and #8431