fix(fetch): use || for CRLF check in multipart formdata-parser#5049
Open
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Open
fix(fetch): use || for CRLF check in multipart formdata-parser#5049deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
The CRLF validation in `parseMultipartFormDataHeaders` and the content-disposition attribute loop incorrectly used `&&` instead of `||`. With `&&`, the parser only failed/terminated when *both* bytes mismatched CRLF, so a stray `\r` (not followed by `\n`) or `\n` (not preceded by `\r`) was silently accepted. This could drop subsequent attributes such as `filename` and misalign header/body boundary detection. The other CRLF checks in the same file already use `||`. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
==========================================
+ Coverage 93.03% 93.04% +0.01%
==========================================
Files 110 110
Lines 35793 35793
==========================================
+ Hits 33299 33303 +4
+ Misses 2494 2490 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRLF validation in
parseMultipartFormDataHeadersand the content-disposition attribute loop incorrectly used&&instead of||. With&&, the parser only failed/terminated when both bytes mismatched CRLF, so a stray\r(not followed by\n) or\n(not preceded by\r) was silently accepted. This could drop subsequent attributes such asfilenameand misalign header/body boundary detection. The other CRLF checks in the same file already use||.