fix(http2): use kSocket instead of kClient for socket in onPing callback#5037
Draft
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Draft
fix(http2): use kSocket instead of kClient for socket in onPing callback#5037deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
In the onPing callback within onHttp2SendPing, the `socket` variable was incorrectly assigned `this[kClient]` (the client object) instead of `this[kSocket]` (the actual socket). This caused `socket[kError] = error` to set the error on the client object rather than the socket, so downstream code checking `socket[kError]` would miss the error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
reviewed
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5037 +/- ##
==========================================
+ Coverage 93.03% 93.05% +0.01%
==========================================
Files 110 110
Lines 35793 35793
==========================================
+ Hits 33301 33306 +5
+ Misses 2492 2487 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the onPing callback within onHttp2SendPing, the
socketvariable was incorrectly assignedthis[kClient](the client object) instead ofthis[kSocket](the actual socket). This causedsocket[kError] = errorto set the error on the client object rather than the socket, so downstream code checkingsocket[kError]would miss the error.