fix: update Content-Type header when body is re-extracted on redirect#4704
Open
brunorodmoreira wants to merge 1 commit intonodejs:mainfrom
Open
fix: update Content-Type header when body is re-extracted on redirect#4704brunorodmoreira wants to merge 1 commit intonodejs:mainfrom
brunorodmoreira wants to merge 1 commit intonodejs:mainfrom
Conversation
When a multipart/form-data POST request encounters a redirect (e.g., 307), the body is re-extracted via safelyExtractBody(), which generates a new boundary. Previously, only the body was captured and the new Content-Type was discarded, leaving the header with the stale boundary. This fix captures the Content-Type returned by safelyExtractBody() and updates the request headers accordingly, ensuring the boundary in the header matches the boundary in the body. Fixes: nodejs#4065
KhafraDev
requested changes
Dec 18, 2025
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
This is likely a patch for a larger, still unfixed bug. Otherwise I would expect other implementations to have similar issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4065
Rationale
When a
multipart/form-dataPOST request encounters a redirect (e.g., 307), the body is re-extracted viasafelyExtractBody(), which generates a new boundary. The original code only captured the body[0]and discarded the newContent-Type[1], leaving the header with the stale boundary.This fix captures the Content-Type returned by
safelyExtractBody()and updates the request headers accordingly, ensuring the boundary in the header matches the boundary in the body.Changes
Features
N/A
Bug Fixes
Content-Typeheader when body is re-extracted during redirect handling, ensuring the boundary in the header matches the boundary in the body.Breaking Changes and Deprecations
N/A
Status