Skip to content

feat(download): add asdf install method#8918

Closed
Herrtian wants to merge 1 commit into
nodejs:mainfrom
Herrtian:add-asdf-download-method-8488
Closed

feat(download): add asdf install method#8918
Herrtian wants to merge 1 commit into
nodejs:mainfrom
Herrtian:add-asdf-download-method-8488

Conversation

@Herrtian
Copy link
Copy Markdown

@Herrtian Herrtian commented May 28, 2026

Description

Adds asdf as a Community install method on the downloads page, with an English snippet and no custom icon.

Validation

  • corepack pnpm prettier
  • corepack pnpm --filter @node-core/website lint:js
  • corepack pnpm --filter @node-core/ui-components lint:js
  • corepack pnpm --filter @node-core/ui-components lint:css
  • corepack pnpm --filter @node-core/website lint:types
  • corepack pnpm --filter @node-core/ui-components lint:types
  • corepack pnpm --filter @node-core/website test:unit -- util/__tests__/download.test.mjs
  • corepack pnpm --filter @node-core/ui-components test
  • corepack pnpm --filter @node-core/website build

Related Issues

Fixes #8488

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Herrtian Herrtian requested a review from a team as a code owner May 28, 2026 08:58
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview May 28, 2026 11:40am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Low Risk
Downloads-page content and UI only; no auth, data, or build pipeline changes beyond optional icon handling.

Overview
Adds asdf as a community install option on the downloads page for macOS and Linux, with a new bash snippet (plugin add, install, global set) and copy in the code box.

Wires it through InstallationMethod, installMethods in constants (no custom icon), and an English platformInfo.asdf string. createIcon now treats a missing or unknown icon as optional so methods without an icon still render in the dropdown.

Reviewed by Cursor Bugbot for commit 738d649. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why theses changes ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this CSS change; it was not needed for adding asdf.

Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ASDF as Community option for install suggestions on download page

3 participants