Skip to content

feat(ci): add zizmor#8728

Open
avivkeller wants to merge 3 commits intomainfrom
zizmor
Open

feat(ci): add zizmor#8728
avivkeller wants to merge 3 commits intomainfrom
zizmor

Conversation

@avivkeller
Copy link
Member

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller requested a review from a team as a code owner March 16, 2026 21:59
Copilot AI review requested due to automatic review settings March 16, 2026 21:59
@vercel
Copy link

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 18, 2026 2:09pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated GitHub Actions workflow to run zizmor for security analysis of this repository’s GitHub Actions configuration, aligning with the referenced web-team security initiative.

Changes:

  • Introduces a new workflow that runs on push and pull_request to main.
  • Uses pinned SHAs for actions/checkout and zizmorcore/zizmor-action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/f782acd83beef83f.js 208.90 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/7ca6b57274045541.js 208.90 KB

Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattIPv4
Copy link
Member

🤔 I don't see this having run on this PR? I would imagine there will be a lot of changes to other workflows required before Zizmor can pass?

@avivkeller
Copy link
Member Author

🤔 I don't see this having run on this PR? I would imagine there will be a lot of changes to other workflows required before Zizmor can pass?

I copied this workflow from Zizmor's documentation, I can, of course, remove that trigger.

Im not sure if it will fail PRs, or just report them as having security concerns.

Perhaps I should push another commit with the fixes to the issues it would find?

@MattIPv4
Copy link
Member

MattIPv4 commented Mar 16, 2026

We're also going to want a branch ruleset change I imagine to block PRs where we have Zizmor failings if we're using the advanced security mode?

@MattIPv4
Copy link
Member

Im not sure if it will fail PRs, or just report them as having security concerns.

It will just report them unless we add a new rule. But, I don't see it running at all? It would show up as a passing Actions check still as it is being run on the PR trigger?

@avivkeller
Copy link
Member Author

Im not sure if it will fail PRs, or just report them as having security concerns.

It will just report them unless we add a new rule. But, I don't see it running at all? It would show up as a passing Actions check still as it is being run on the PR trigger?

It won't run on this PR, since it's the one that added it (GitHub is weird that way)

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.12%. Comparing base (783305e) to head (e9abd33).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8728   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files         104      104           
  Lines        9167     9167           
  Branches      315      315           
=======================================
  Hits         6887     6887           
  Misses       2278     2278           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@avivkeller avivkeller added this pull request to the merge queue Mar 18, 2026
@avivkeller
Copy link
Member Author

@nodejs/web-admins remember to add the action to the allowlist

@MattIPv4 MattIPv4 removed this pull request from the merge queue due to a manual request Mar 18, 2026
@MattIPv4
Copy link
Member

It won't run on this PR, since it's the one that added it (GitHub is weird that way)

This is false... When you add a new workflow with a pull_request trigger, it will run on the PR that introduces it (assuming the PR isn't a fork).

@nodejs/web-admins remember to add the action to the allowlist

This is why the workflow hasn't run, if you'd actually checked...

image

https://github.com/nodejs/nodejs.org/actions/runs/23171995051

Let's actually check the workflow runs and works before we blindly merge the change, please.

@MattIPv4
Copy link
Member

I've added the action to the list. If you can push a change to cause the CI to run again, that'd be appreciated so we can actually validate the workflow is going to work.

@github-advanced-security
Copy link

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@avivkeller
Copy link
Member Author

This is why the workflow hasn't run, if you'd actually checked...

I'm sorry I was mistaken previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants