ffi: reject detached ArrayBuffers as pointers - #65083
Open
trivikr wants to merge 5 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
trivikr
force-pushed
the
ffi-detached-arraybuffers-null
branch
2 times, most recently
from
August 7, 2026 02:58
3713f90 to
6aa48c5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65083 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01%
==========================================
Files 760 760
Lines 248526 248595 +69
Branches 46886 46911 +25
==========================================
+ Hits 224439 224496 +57
- Misses 15515 15528 +13
+ Partials 8572 8571 -1
🚀 New features to boost your workflow:
|
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
marked this pull request as draft
August 11, 2026 05:17
This comment was marked as outdated.
This comment was marked as outdated.
Reject detached ArrayBuffers and ArrayBuffer views in getRawPointer() and FFI pointer argument conversion. This prevents detached backing stores from being silently passed to native functions as null pointers. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Report that the ArrayBuffer is detached instead of describing its backing store as invalid. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
ffi: reject detached ArrayBuffers as pointers Reject detached ArrayBuffers and ArrayBuffer views in getRawPointer() and all FFI pointer argument conversion paths, including optimized fast calls. This prevents detached backing stores from being silently passed to native functions as null pointers. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
ffi-detached-arraybuffers-null
branch
from
August 11, 2026 05:32
6aa48c5 to
99ac691
Compare
trivikr
marked this pull request as ready for review
August 11, 2026 05:33
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
ShogunPanda
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65082
Reject detached ArrayBuffers and ArrayBuffer views in getRawPointer() and all FFI pointer argument conversion paths, including optimized fast calls. This prevents detached backing stores from being silently passed to native functions as null pointers.
Assisted-by: codex:gpt-5.6-sol