Skip to content

test_runner: scope file-level hooks per file in --test-isolation=none#62283

Open
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix/beforeeach-leak-no-isolation
Open

test_runner: scope file-level hooks per file in --test-isolation=none#62283
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix/beforeeach-leak-no-isolation

Conversation

@geeksilva97
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 16, 2026
@geeksilva97 geeksilva97 force-pushed the fix/beforeeach-leak-no-isolation branch from e7bb929 to 9a311e9 Compare March 16, 2026 17:52
@geeksilva97 geeksilva97 marked this pull request as ready for review March 16, 2026 17:59
@geeksilva97 geeksilva97 added the wip Issues and PRs that are still a work in progress. label Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (4579957) to head (9a311e9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62283      +/-   ##
==========================================
- Coverage   89.67%   89.67%   -0.01%     
==========================================
  Files         676      676              
  Lines      206555   206537      -18     
  Branches    39554    39564      +10     
==========================================
- Hits       185230   185203      -27     
+ Misses      13461    13457       -4     
- Partials     7864     7877      +13     
Files with missing lines Coverage Δ
lib/internal/test_runner/runner.js 93.06% <100.00%> (-0.13%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. wip Issues and PRs that are still a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants