Skip to content

build: skip dockit on riscv64 - #62251

Open
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:nodoc_riscv64
Open

build: skip dockit on riscv64#62251
sxa wants to merge 2 commits into
nodejs:mainfrom
sxa:nodoc_riscv64

Conversation

@sxa

@sxa sxa commented Mar 14, 2026

Copy link
Copy Markdown
Member

The doc-only target gives a variety of failures on different riscv64 systems. These symptoms are described in nodejs/build#4099 (comment) in the section Additional info on the Wasm doc-only crash

This removes the doc-only target from being run by default as part of make test-ci similar to what has been done for AIX and IBMi.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Mar 14, 2026
@sxa
sxa marked this pull request as draft March 14, 2026 10:58
@codecov

codecov Bot commented Mar 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (8ccbe8e) to head (c15711f).
⚠️ Report is 1864 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62251      +/-   ##
==========================================
+ Coverage   89.68%   90.05%   +0.37%     
==========================================
  Files         676      751      +75     
  Lines      206495   254919   +48424     
  Branches    39537    48124    +8587     
==========================================
+ Hits       185204   229580   +44376     
- Misses      13435    16495    +3060     
- Partials     7856     8844     +988     

see 523 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kxxt

kxxt commented Mar 21, 2026

Copy link
Copy Markdown
Member

I think we can fix it (at least the WebAssembly.instantiate(): Out of memory: Cannot allocate Wasm memory for new instance part) by bumping @nodejs/doc-kit after nodejs/doc-kit#691 is merged.

@kxxt

kxxt commented Apr 11, 2026

Copy link
Copy Markdown
Member

by bumping @nodejs/doc-kit after nodejs/doc-kit#691 is merged.

#62686

@sxa

sxa commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Probably fixed with the updae in #62512 - running a test on my K1 at https://ci.nodejs.org/job/sxa-rvnodetest/399/

@sxa sxa self-assigned this Aug 26, 2026
@sxa

sxa commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Noting that I hit this again today with a branch that had the doc-kit 1.4.1 added in https://github.com/nodejs/node/pull/64010/changes so this may still be required.

0:52:24 cp -r doc/api out/doc
20:52:25 npm warn cli npm v11.17.0 does not support Node.js v26.5.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
20:52:36 
20:52:36 added 280 packages, and audited 282 packages in 11s
20:52:36 
20:52:36 137 packages are looking for funding
20:52:36   run `npm fund` for details
20:52:36 
20:52:36 1 moderate severity vulnerability
20:52:36 
20:52:36 To address all issues, run:
20:52:36   npm audit fix
20:52:36 
20:52:36 Run `npm audit` for details.
20:53:25 [19:53:25.175] ERROR: WebAssembly.Instance(): Out of memory: Cannot allocate Wasm memory for new instance
20:53:25 RangeError: WebAssembly.Instance(): Out of memory: Cannot allocate Wasm memory for new instance

Ref: https://ci.nodejs.org/job/sxa-node-test-commit-rvlinux/14/nodes=riscv64

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa

sxa commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Apparently the variable name in this PR didn't work for the check - changed from DESTCPU to ARCHTYPE which is the variable used for detecting arm64 elsewhere in the Makefile.

@sxa
sxa marked this pull request as ready for review August 27, 2026 19:48
@sxa sxa added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@sxa

sxa commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

request-ci hasn't taken effect - triggered manually at https://ci.nodejs.org/job/node-test-pull-request/76624

Noting that the request-ci triggers have been playing up. Ref: nodejs/build#4443

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants