Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 80.60% 80.59% -0.02%
==========================================
Files 126 126
Lines 12132 12134 +2
Branches 874 874
==========================================
Hits 9779 9779
- Misses 2350 2352 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Simplifies legacyToJSON serialization logic used by the legacy JSON generators, including a dedicated output shape for the consolidated all.json payload.
Changes:
- Add a nullish-
apibranch to emitall.jsonwith a specific key order. - Simplify per-section JSON serialization by removing the previous
api === 'report'ordering special-case while preserving theindex-modulemodulesomission.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avivkeller
left a comment
There was a problem hiding this comment.
Once downstream is good, I think this function can be removed entirely, can it not?
avivkeller
left a comment
There was a problem hiding this comment.
Ahh, I see the PR linked is a new PR, not the tooling PR
|
@ovflowd please wait for fast track approval, as this should not have landed yet |
No? I approved the fast-track. Only author cannot self-approve fast-track. |
|
But this wasn't ready to land, it should've waited for another PR. I know I'm guilty of self-approving fast tracks, but perhaps we should change that rule to require an extra approval? |
It wouldn't really have mattered, as ultimately the actual PR introducing doc-kit wouldn't be merged anyways. |
|
But to answer this better, it's more that I didn't realize this PR was not ready to be merged 😅 (cc @avivkeller) a mark as draft or block label would have helped, that's my bad. |
Description
Simplification that can land once nodejs/node#61757 have landed downstream
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.