Skip to content

docs: expand contribution guide - #4466

Open
vittorioexp wants to merge 1 commit into
nitrojs:mainfrom
vittorioexp:docs/improve-contributing-guide
Open

docs: expand contribution guide#4466
vittorioexp wants to merge 1 commit into
nitrojs:mainfrom
vittorioexp:docs/improve-contributing-guide

Conversation

@vittorioexp

Copy link
Copy Markdown
Contributor

Summary

Closes #2213.

Expands CONTRIBUTING.md with contribution types (docs, bug fixes, features, presets, examples) and a pull request checklist.

Test plan

  • Docs-only change

Add contribution types table and PR checklist for fixes, features, presets, and docs. Closes nitrojs#2213.
@vittorioexp
vittorioexp requested a review from pi0 as a code owner July 22, 2026 10:23
@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

@vittorioexp is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

CONTRIBUTING.md now includes contribution-type guidance and a pull request checklist covering titles, issues, tests, documentation, and provider testing.

Changes

Contribution guide

Layer / File(s) Summary
Contribution guidance and pull request checklist
CONTRIBUTING.md
Adds contribution locations and notes for documentation, fixes, features, presets, and examples, plus pull request requirements.
Estimated code review effort: 1 (Trivial) ~2 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commit format and clearly matches the docs-only contribution guide update.
Description check ✅ Passed The description directly summarizes the CONTRIBUTING.md expansion and matches the documented change.
Linked Issues check ✅ Passed The PR adds contribution guidance for fixes, features, and presets as requested by issue #2213.
Out of Scope Changes check ✅ Passed The changes stay within the contribution guide update and do not introduce unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Around line 31-32: Update the pull request checklist in CONTRIBUTING.md to
strengthen bug-fix guidance by requiring a minimal reproduction or relevant
context, and add the security-fix requirement directing contributors to report
through SECURITY.md before opening a PR. Preserve the existing
conventional-commit and related-issue checklist items.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a9140ed-0100-4295-991c-0c3e0d0c84a9

📥 Commits

Reviewing files that changed from the base of the PR and between c1ff6ba and 35ee415.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Comment thread CONTRIBUTING.md
Comment on lines +31 to +32
- Use [conventional commits](https://www.conventionalcommits.org/) in the PR title (for example `fix(preset): …`, `docs: …`, `feat: …`).
- Link the related issue when one exists.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Align the checklist with the repository PR template.

The checklist omits the existing security-fix requirement and weakens the bug-fix guidance. Please mention that bug-fix issues should include a minimal reproduction/context, and that security fixes must be reported through SECURITY.md before opening a PR.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` around lines 31 - 32, Update the pull request checklist in
CONTRIBUTING.md to strengthen bug-fix guidance by requiring a minimal
reproduction or relevant context, and add the security-fix requirement directing
contributors to report through SECURITY.md before opening a PR. Preserve the
existing conventional-commit and related-issue checklist items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve contribution guide

1 participant