feat: Add filterType property to work item and work item template APIs models - #228
Merged
gokulprasanth-ni merged 7 commits intoSep 23, 2026
Conversation
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
gokulprasanth-ni
requested review from
snehaa-ni
and
a lite review from Copilot
September 9, 2026 12:31
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is additive, follows existing JsonModel camelCase serialization conventions, and includes integration test coverage plus updated examples for the new field.
Pull request overview
Adds a filterType/filter_type field to Work Item and Work Item Template resource models so callers can explicitly indicate whether resource filters are interpreted as LINQ or LUCENE, and updates integration tests/examples to exercise and document the new behavior.
Changes:
- Introduces
FilterTypeenum and addsfilter_typetoResourcesDefinitionandTemplateResourcesDefinition(serialized asfilterType). - Extends query projection enums with
RESOURCES_FILTER_TYPEfor both work items and templates. - Updates integration tests and examples to set and validate
filter_type(and adjusts sample filter strings accordingly).
File summaries
| File | Description |
|---|---|
| tests/integration/work_item/test_work_item_client.py | Adds integration coverage for create/update/query behaviors involving resources.filter_type and updates sample filters. |
| nisystemlink/clients/work_item/models/_resources_definition.py | Adds FilterType enum plus filter_type fields to resource definition models. |
| nisystemlink/clients/work_item/models/_query_work_items_request.py | Adds WorkItemField.RESOURCES_FILTER_TYPE projection field. |
| nisystemlink/clients/work_item/models/_query_work_item_templates_request.py | Adds WorkItemTemplateField.RESOURCES_FILTER_TYPE projection field. |
| nisystemlink/clients/work_item/models/init.py | Exports FilterType from the public models package. |
| examples/work_item/work_items.py | Demonstrates setting filter_type for work item create/update resource filters. |
| examples/work_item/work_item_templates.py | Demonstrates setting filter_type for template resource filters and updates. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
snehaa-ni
approved these changes
Sep 9, 2026
added 5 commits
September 21, 2026 23:13
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
gokulprasanth-ni
marked this pull request as ready for review
September 21, 2026 18:11
gokulprasanth-ni
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
September 21, 2026 18:11
rbell517
approved these changes
Sep 21, 2026
Signed-off-by: gokulprasanth-ni <gokulprasanth.ravi@emerson.com>
gokulprasanth-ni
deleted the
users/gokulprasanthRavi/add-filter-type-support-to-workitems-client
branch
September 23, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add filterType property to resource models in work item and template APIs
Why should this Pull Request be merged?
This support makes it easier for the users to create work items with either
LinqorLuceneresource filtersWhat testing has been done?
Automated integration tests are included.