Remove import of snakemake.io.Wildcards#72
Merged
joverlee521 merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
`Wildcards` has been moved in Snakemake 9.17.0¹ and again in 9.18.0.² The import was non-functional and for typing purposes only, so just remove the import and not rely on Snakemake internals as discussed in <nextstrain/public#39> ¹ <snakemake/snakemake@ffb19e7> ² <snakemake/snakemake@2ed2c23>
1 task
jameshadfield
approved these changes
Mar 31, 2026
Member
jameshadfield
left a comment
jameshadfield
left a comment
There was a problem hiding this comment.
Typing in python is such a mixed bag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Wildcardshas been moved in Snakemake 9.17.0¹ and again in 9.18.0.² The import was non-functional and for typing purposes only, so just remove the import and not rely on Snakemake internals as discussedin nextstrain/public#39
¹ snakemake/snakemake@ffb19e7
² snakemake/snakemake@2ed2c23
Checklist
If adding a script, add an entry for it in the README.