Skip to content

Continuing Bubble Implementation#5928

Open
rapterjet2004 wants to merge 2 commits into
masterfrom
issue-3385-arlex-attempt
Open

Continuing Bubble Implementation#5928
rapterjet2004 wants to merge 2 commits into
masterfrom
issue-3385-arlex-attempt

Conversation

@rapterjet2004

@rapterjet2004 rapterjet2004 commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ToDo

  • refactor ChatActivity after rebase on master to solve merge conflicts see
  • review and implement claude suggestions

Changes

  • Refactoring NotificationUtils.createConversationBubble to use kotlin flows and best practices
  • Refactoring NotificationWorker.addBubble for clarity and reducing nesting, using the return-if-error technique, and the proper usage of the builder pattern for all functions related to the bubble feature
  • Added better error handling

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Mar 4, 2026
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Mar 4, 2026
@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from 56dcd8e to 90a4fa3 Compare March 9, 2026 14:53
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 9, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/talk/utils/NotificationUtils.kt Dismissed
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 11, 2026
@sowjanyakch

This comment was marked as resolved.

Sign in to view
@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from a90d336 to 315ee3b Compare March 16, 2026 18:04
@github-actions

github-actions Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5928.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi

mahibi commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

i wanted to review but #5979 happens to me again

@mahibi

mahibi commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

giving it another try.
Somehow i don't get bubbled conversations anymore when i change it in the settings.
Only when i go to a chat and explicitly select "Create bubble", then a bubble is created.
But as soon as i get a push, the bubble disappears instead to show the notification.

@rapterjet2004 does it work for you as expected?

@mahibi mahibi force-pushed the issue-3385-arlex-attempt branch from 2826d6a to 933a46b Compare April 2, 2026 14:37
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/23905922700/artifacts/6243947187
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi

This comment was marked as outdated.

Sign in to view
This was referenced Apr 2, 2026
Closed
Merged
@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch 4 times, most recently from 6ed3553 to 87c5130 Compare April 2, 2026 16:47
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/23946962562/artifacts/6259706638
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/23948011150/artifacts/6260084009
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from 1a3fb2f to d174829 Compare April 8, 2026 14:54
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24193631626/artifacts/6351236070
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from c185810 to 1fd84eb Compare April 10, 2026 14:15
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24247358242/artifacts/6372834294
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24249183788/artifacts/6373597825
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger requested a review from Copilot April 10, 2026 19:07

This comment was marked as resolved.

Sign in to view

@mahibi

mahibi commented May 5, 2026

Copy link
Copy Markdown
Collaborator

@rapterjet2004 could you have a look at the copilot review and rebase on master?

@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch 2 times, most recently from 54da9ac to 656ef32 Compare May 21, 2026 15:54
@mahibi mahibi force-pushed the issue-3385-arlex-attempt branch from 656ef32 to 35c9a7e Compare May 29, 2026 13:48
@mahibi

This comment was marked as resolved.

Sign in to view
@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from 35c9a7e to b2a7ce4 Compare June 9, 2026 17:59
@rapterjet2004 rapterjet2004 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/27284350811/artifacts/7540177010
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from 6f0a834 to 78b1e17 Compare June 16, 2026 16:32
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/27632722994/artifacts/7673649848
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/27635840582/artifacts/7674811967
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

arlexTech and others added 2 commits June 22, 2026 13:03
@arlexTech @rapterjet2004
- Refactoring addBubble for clarity and reducing nesting
7800e87 
- Refactoring createConversationBubble to use best practices, keeping ChatActivity.kt simple
- Refactoring NotificationWorker functions related to bubbling to now properly follow the builder pattern
- better error handling of edge cases
- reimplementing UI in jetpack compose after rebase

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
AI suggestions
e46b2c1 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-3385-arlex-attempt branch from 0459b65 to e46b2c1 Compare June 22, 2026 18:04
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/27973693747/artifacts/7801069917
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels

2. developing Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ability to "bubble" conversations

6 participants

@rapterjet2004 @sowjanyakch @mahibi @github-advanced-security @arlexTech