Skip to content

Add Push Notification with Play Service on generic flavor (full FLOSS)#5884

Merged
mahibi merged 4 commits into
nextcloud:masterfrom
p1gp1g:foss_fcm
Jun 23, 2026
Merged

Add Push Notification with Play Service on generic flavor (full FLOSS)#5884
mahibi merged 4 commits into
nextcloud:masterfrom
p1gp1g:foss_fcm

Conversation

@p1gp1g

@p1gp1g p1gp1g commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

This PR is based on #5883, it is marked as draft until the previous PR is merged

It adds a component, FCM embedded UnifiedPush distributor, that allows to get push notifications with the Play Services, without using firebase-messaging, and the proprietary libs. It is therefore compatible with F-Droid inclusion.

It gives Play Services notifications with web push requests: so the notification proxy, isn't used

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi

mahibi commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

Thank you so much @p1gp1g i'm really looking forward to have UnifiedPush implemented 👍 👍 👍
We will take a close look as soon as time allows, it might not be this week though.

@mahibi

mahibi commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

i won't find the time this week. It's on my list though

@mahibi

mahibi commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

It's not forgotten. Will come back

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@mahibi

mahibi commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

@p1gp1g please excuse the delay, we will have a closer look soon.
Are you willing to fix the merge conflicts?

@mahibi

mahibi commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Hi @p1gp1g
due to upcoming vacations in plan to review this PR in CW16.

@mahibi

mahibi commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

I'm back. Planning to have a look this week

@p1gp1g

p1gp1g commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

OK, I'm resolving conflicts then 👍

@p1gp1g p1gp1g force-pushed the foss_fcm branch 2 times, most recently from 3b97fa7 to 5209cfd Compare April 13, 2026 13:58
@p1gp1g

p1gp1g commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

#5883 and this PR are rebased

@mahibi mahibi self-assigned this Apr 22, 2026
@mahibi mahibi self-requested a review April 22, 2026 08:03
@mahibi

mahibi commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

assigned myself just to keep an overview

@mahibi

mahibi commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Please excuse the current delays in pull request reviews.
The PR is on our list.

@p1gp1g p1gp1g mentioned this pull request Apr 30, 2026
5 tasks
@p1gp1g p1gp1g changed the title Draft: Add Push Notification with Play Service on generic flavor (full FLOSS) Add Push Notification with Play Service on generic flavor (full FLOSS) May 4, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member

@p1gp1g despite the rebase it shows 3 conflicted files, did you rebase to latest main branch of Nextcloud or your remote?

@p1gp1g

p1gp1g commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

I rebased on my unifiedpush branch which got merged. I'm rebasing to the master branch to fix the conflicts - I've also a commit to sign

@p1gp1g

p1gp1g commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

I'm taking time, because I'm updating the library in the same time

@p1gp1g

p1gp1g commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

OK, it's done now 👍

@mahibi

mahibi commented May 12, 2026

Copy link
Copy Markdown
Collaborator

We are now trying to catch up with the pull request reviews. The PR is not forgotten and should be picked up soon.

@mahibi

mahibi commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Apologies for the delay, i was out sick for a week and now try to catch up

@p1gp1g

p1gp1g commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

No problem. I hope you're getting better 👍

@mahibi

mahibi commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Review is planned for this week

@mahibi

mahibi commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

still on my list..

@mahibi

mahibi commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

planning it again for this week ;)

@mahibi mahibi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, great work @p1gp1g 🥇
Please excuse the long delay, it depended on internal discussions.

When the suggestions are implemented and it's rebased on master we should be ready to merge.

Comment thread app/build.gradle.kts Outdated
Comment thread app/build.gradle.kts Outdated
Comment thread app/src/main/java/com/nextcloud/talk/diagnosis/DiagnosisActivity.kt Outdated
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 💬 Talk team Jun 23, 2026
@p1gp1g

p1gp1g commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I think I've resolved all your comments!

@mahibi

mahibi commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

I think I've resolved all your comments!

👍 could you sync with the origin repo and rebase on the latest changes?

@p1gp1g

p1gp1g commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

The PR is rebased

@p1gp1g

p1gp1g commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I've pushed again after a lint

@mahibi mahibi merged commit d11b66f into nextcloud:master Jun 23, 2026
15 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💬 Talk team Jun 23, 2026
@mahibi

mahibi commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Thank you @p1gp1g , great job 👍

@p1gp1g

p1gp1g commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Great! It’s really nice to see that the contributions are well received 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants