fix(core): report full relative paths in integrity checker for apps#62332
Open
gitedmond wants to merge 2 commits into
Open
fix(core): report full relative paths in integrity checker for apps#62332gitedmond wants to merge 2 commits into
gitedmond wants to merge 2 commits into
Conversation
Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the output reports the full, correct path (e.g. apps/twofactor_totp/js/... instead of js/...). Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Edmond <edmnd@users.noreply.github.com>
gitedmond
force-pushed
the
fix/integrity-path-prefix
branch
from
July 19, 2026 18:38
e75b64d to
2fdbc65
Compare
gitedmond
marked this pull request as ready for review
July 19, 2026 18:49
gitedmond
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
July 19, 2026 18:49
…allback Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Edmond <edmnd@users.noreply.github.com>
gitedmond
force-pushed
the
fix/integrity-path-prefix
branch
from
July 20, 2026 14:20
a16c2da to
a2f1caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepend the relative app folder and app ID to reported filenames when verifying app signatures to report full relative paths in the integrity checker.
Assisted-by: Antigravity:Gemini-3.5-Flash
Summary
Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the integrity check list output reports the full, correct path (e.g.
apps/twofactor_totp/js/...instead ofjs/...) for missing or modified app-specific files.Right now, if an app file fails verification, the integrity scanner only reports the path inside the app folder itself (like
js/...instead ofapps/twofactor_totp/js/...). This pr just prepends the app's relative directory to the path so you actually know where to look when files go missing.Changes
verify()insidelib/private/IntegrityCheck/Checker.phpto prefix reported app filenames with their relative directory path resolved via theEnvironmentHelper(or standardapps/layout).tests/lib/IntegrityCheck/CheckerTest.phptests to align with the new prefixed path format.Checklist
git commit --amend -son the branch to add your DCO signature)3. to review, feature component)stable32)AI (if applicable)