test(files): make watcher propagation mtime regression test deterministic#62329
Open
joshtrichards wants to merge 2 commits into
Open
test(files): make watcher propagation mtime regression test deterministic#62329joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
- The existing watcher regression test could pass if the cached mtime and request timestamp land in the same second. - The test now uses a fixed root mtime and etag before accessing the folder. - Checking the etag as well is valid, because an unwanted propagation can invalidate ancestor etags. Assisted-by: GitHubCopilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
July 19, 2026 16:05
joshtrichards
added
3. to review
Signed-off-by: Josh <josh.t.richards@gmail.com>
Antreesy
reviewed
Jul 20, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Looks good and makes sense to me, but I'm leaving the decision to PHP experts.
Thanks for the follow-up!
CarlSchwan
approved these changes
Jul 21, 2026
Antreesy
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related/context: #59539
Assisted-by: GitHubCopilot:GPT-5
Checklist
3. to review, feature component)stable32)AI (if applicable)