fix: treat all WebKit iOS browseres the same#59168
Open
philiprenich wants to merge 1 commit intonextcloud:masterfrom
Open
fix: treat all WebKit iOS browseres the same#59168philiprenich wants to merge 1 commit intonextcloud:masterfrom
philiprenich wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Philip Renich <hello@philiprenich.com>
philiprenich
requested review from
ArtificialOwl,
CarlSchwan,
come-nc and
icewind1991
and removed request for
a team
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the user agent regex used to detect browsers on iOS. Since all browsers there currently use WebKit and render as Mobile Safari, they should be treated the same. The regex does not match the potential upcoming EU-only Gecko-based mobile Firefox. Here is a sample of matching and unmatching UA strings
I also simplified the regex after researching various iPhone/iPad UA strings across the years and models.
Tested In
iOS...
Checklist
3. to review, feature component)stable32)AI (if applicable)