fix(files): preserve destination path for dropped directories#58951
Open
Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Open
fix(files): preserve destination path for dropped directories#58951Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Zhey-on wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Zhey <anpropagate@aol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dropping a folder into a subdirectory was creating missing directories with a path that did not include the destination folder.
In practice, that sent WebDAV requests to the wrong location and produced
PROPFIND 404/PUT 404for nested folder uploads.This change keeps directory creation anchored to
destination.path, so folder drops into subdirectories stay in the selected target.I also added a regression test that verifies nested directories are created under the destination path.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)