fix(View): safer lock life-cycle handling in basicOperation() + clearer control flow #58947
Draft
joshtrichards wants to merge 6 commits intomasterfrom
Draft
fix(View): safer lock life-cycle handling in basicOperation() + clearer control flow #58947joshtrichards wants to merge 6 commits intomasterfrom
basicOperation() + clearer control flow #58947joshtrichards wants to merge 6 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
use lock-state tracking + centralized finally cleanup Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
Key changes:
basicOperation().Safer lock lifecycle handling:
ILockingProviderlock constants).finallyfor consistent cleanup on both success and error paths.fopenbehavior:finallyskips unlock when ownership is transferred.Refactoring:
read/write/delete/touch/create) into local booleans.This is primarily a maintainability/safety refactor with no intended functional change.
The previous structure made lock transitions and cleanup paths harder to reason about; this makes lock ownership and release paths explicit and lowers regression risk.
Review tip: Easiest to review commit-by-commit
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)