Skip to content

refactor(accountManager): small fixes, optimizations and strict typing and#58906

Open
solracsf wants to merge 1 commit intomasterfrom
accMgrOpti
Open

refactor(accountManager): small fixes, optimizations and strict typing and#58906
solracsf wants to merge 1 commit intomasterfrom
accMgrOpti

Conversation

@solracsf
Copy link
Member

Summary

Among others:

  • Replaced error-prone json_last_error() checks with the JSON_THROW_ON_ERROR flag, explicitly catching JsonException to prevent silent serialization failures.
  • Promoted all injected constructor dependencies and immutable class variables
  • Replaced verbose anonymous closures
  • Implemented null coalescing assignment operators

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@solracsf solracsf added 2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 13, 2026
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 13, 2026
@solracsf solracsf added this to the Nextcloud 34 milestone Mar 13, 2026
@solracsf solracsf changed the title refactor(accountManager): PHP 8.2 optimizations, strict typing and small fixes refactor(accountManager): small fixes, optimizations and strict typing and Mar 13, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf marked this pull request as ready for review March 13, 2026 17:53
@solracsf solracsf requested a review from a team as a code owner March 13, 2026 17:53
@solracsf solracsf requested review from leftybournes, nfebe, salmart-dev and sorbaugh and removed request for a team March 13, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant