feat(OCP): Expose setup manager to OCP#57826
Merged
CarlSchwan merged 2 commits intomasterfrom Jan 28, 2026
Merged
Conversation
It's used by a lot of apps so expose just the two methods that are most of the time used, to prevent the apps to relly on private APIs. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
requested review from
ArtificialOwl,
artonge,
icewind1991 and
salmart-dev
and removed request for
a team
CarlSchwan
force-pushed
the
carl/setupmanager
branch
from
a0cc928 to
123ca40
Compare
come-nc
reviewed
Jan 27, 2026
provokateurin
approved these changes
Jan 27, 2026
Keep using the OC API in the mount manager and OC_Utils, but the rest is now using the public API. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/setupmanager
branch
from
123ca40 to
ae73f7a
Compare
icewind1991
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's used by a lot of apps so expose just the two methods that are most of the time used, to prevent the apps to relly on private APIs.
TODO
Checklist
3. to review, feature component)stable32)