chore!: drop jQuery UI and jQuery #57648
Draft
+13
−4,673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
2. developing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
It is deprecated since 29.0.0. Instead use `openConflictPicker` from the `@nextcloud/upload` (Vue 2). Or from `@nextcloud/dialogs` (every other framework like Vue 3 etc). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Deprecated since 17.0.0, use the `@nextcloud/dialogs` package instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Instead use components from `@nextcloud/vue` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Instead use Vue components. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…tcloud/vue/components/NcDateTime` instead Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Use the DAV client from `@nextcloud/files/dav` instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
"jQuery is deprecated and will be removed with Nextcloud 19" Well... At least it is removed now 😉 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/drop-jquery
branch
from
5550b87 to
d8189c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Well no it was not. But it is now with Nextcloud 34.
This PR removed all jQuery UI related code:
OC.Dialogs.fileexists-> use@nextcloud/dialogsinsteadOC.Notifications-> use@nextcloud/dialogsinsteadOC.Apps-> use@nextcloud/vuecomponentsOC.*menu*-> use@nextcloud/vuecomponents.live-relative-timestamp-> useNcDateTimefrom@nextcloud/vuesnapper-> useNcAppNavigationfrom@nextcloud/vueOC.Files.ClientTODO
Requires this first:
OC.EventSourcefrom jQuery to native API #57644WhatsNew#57583Checklist
3. to review, feature component)stable32)