fix(sync): apply activity interval before scheduling - #13710
Open
abhinavohri wants to merge 1 commit into
Open
abhinavohri wants to merge 1 commit into
abhinavohri wants to merge 1 commit into
Conversation
Nextcloud checks a timed job interval before run(), so changing it during sync cannot affect when the job is selected. Set the activity-based interval when the account argument is loaded, while preserving administrator overrides. Assisted-by: Codex:gpt-5 Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
abhinavohri
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
September 20, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13620
Summary:
SyncJobset its activity-based interval inrun(), after Nextcloud had decided the job was due. Because that interval was not persisted, hence the inactive accounts kept syncing hourly.Shifting the logic to
setArgument()lets Nextcloud use the correct interval when it makes the due decision.