Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
luca9913
force-pushed
the
feat/settings/customizable-message-id
branch
from
September 16, 2026 14:40
f3e23a3 to
dd0a356
Compare
…used in the message ID header of outgoing mail Signed-off-by: luca9913 <luca_trumpf@protonmail.com>
…ConfigLexicon to inject the custom prefix into the message ID header for outgoing mail and drafts Signed-off-by: luca9913 <luca_trumpf@protonmail.com>
…ffected by the newly introduced setting "message_id_prefix" Signed-off-by: luca9913 <luca_trumpf@protonmail.com>
luca9913
force-pushed
the
feat/settings/customizable-message-id
branch
from
September 16, 2026 14:45
dd0a356 to
d1136f2
Compare
Author
|
I used the wrong name in the sign-off message. I corrected the commit messages to match the expected username by rebasing the commits with the |
luca9913
marked this pull request as ready for review
September 16, 2026 18:17
luca9913
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
September 16, 2026 18:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #624.
Summary
In order to allow users to set their own Message-ID prefix, we introduce an admin setting with a default value 'nextcloud-mail' and use that prefix from the settings to create a RFC 5322 compliant Message-ID header for outgoing mail and drafts.
The wish to "remove the server name" from the Message-ID in the original issue description is not met. The server name is inserted in the Horde library and the function
Horde_Mime_Headers_MessageId::createdoes not accept any argument to "hide" that name.Changes
Settings
MESSAGE_ID_PREFIXtoOCA\Mail\ConfigLexiconwith default value 'nextcloud-mail'getForm()@OCA\Mail\Settings\AdminSettingsusing theinitialStateService/api/settings/messageidprefixin routes.phpsetMessageIdPrefix) toOCA\Mail\Controller#mail-message-id-prefixin theNcSettingsSection@src/components/settings/AdminSettings.vuesrc/service/SettingsService.jsMail transmission
IAppConfigintoOCA\Mail\Service\MailTransmissionto fetch the current value configured in the settingsConfigLexicon::MESSAGE_ID_PREFIXvalue to build a header insendMessage()buildMimeHeaders()that is used bysaveLocalDraft()andsaveDraft()inOCA\Mail\Service\MailTransmissionHow to test
TODO / Open questions
Please add your questions and TODOs
Checklist
🤖 AI (if applicable)