fix(ui): remove redundant envelope fetch on mailbox switch#13220
Open
ChristophWurst wants to merge 1 commit into
Open
fix(ui): remove redundant envelope fetch on mailbox switch#13220ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
The mailbox watcher fetch was introduced in fe12a29 to fix threads disappearing after a refresh, but that case is fully covered by the guarded calls in mounted() and the route watcher. On every switch to an uninitialized or empty mailbox it duplicated the fetch that the child Mailbox component already performs and threw an unhandled MailboxNotCachedError for mailboxes that were not initialized yet. Assisted-by: Claude:claude-fable-5 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mailbox watcher fetch was introduced in fe12a29 to fix threads disappearing after a refresh, but that case is fully covered by the guarded calls in mounted() and the route watcher. On every switch to an uninitialized or empty mailbox it duplicated the fetch that the child Mailbox component already performs and threw an unhandled MailboxNotCachedError for mailboxes that were not initialized yet.
Ref #10084 (review)
Assisted-by: Claude:claude-fable-5
How to test
main: two identical GETs to fetch messages of the mailbox
here: only one request
🤖 AI (if applicable)