fix(wizard): align reauthentication with account setup by Rello · Pull Request #10459 · nextcloud/desktop

Rello · 2026-07-27T13:37:43Z

Replace the legacy QWidget reauthentication dialog with a QML window that shares the account wizard browser-auth content, footer, dimensions, and style tokens.

Keep credential replacement isolated from account creation and remove the unreachable provider-signup widget stack and its orphaned helpers.

Assisted-by: Codex:GPT-5

Replace the legacy QWidget reauthentication dialog with a QML window that shares the account wizard browser-auth content, footer, dimensions, and style tokens. Keep credential replacement isolated from account creation and remove the unreachable provider-signup widget stack and its orphaned helpers. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1957df8f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-27T13:41:55Z

        | Qt.CustomizeWindowHint
        | Qt.WindowTitleHint
        | Qt.WindowSystemMenuHint
+        | Qt.WindowMinimizeButtonHint


Keep the minimize hint scoped to authentication windows

When opening any existing WizardStyledWindow consumer, this base-level flag now adds minimize decoration to ActivitiesWindow.qml, AssistantWindow.qml, SearchWindow.qml, and UserStatusWindow.qml; previously only AccountWizardWindow.qml explicitly opted into minimization. Keep this hint on the account and reauthentication windows, or explicitly preserve the existing chrome for the other consumers, so the reauthentication refactor does not change unrelated windows.

AGENTS.md reference: AGENTS.md:L25-L27

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f03bdf0288

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Replaced the direct successful slotAuthResult() test with integration coverage through WebFlowCredentials::askFromUser(). Exercises real QML window creation, browser-flow polling, credential replacement, persistence invocation, automatic close, and account-registration safety. Added cancellation coverage by closing the actual QML window and verifying credentials remain unchanged. Added a safe Application null guard for standard Qt test runners. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

Rello · 2026-07-27T19:42:07Z

@claucambra can you check the quite complex test? it applied the new guidelines - but look complicated. opinion?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 90296ac1d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

github-actions · 2026-07-29T06:14:46Z

Artifact containing the AppImage: nextcloud-appimage-pr-10459.zip

Digest: sha256:2093842478f7053d2511e6d360d3ee4b2dc2ea19aac3c545a3755eebe62ef1c3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarqubecloud · 2026-07-29T06:49:36Z

Quality Gate failed

Failed conditions
75.4% Coverage on New Code (required ≥ 80%)
68 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

claucambra · 2026-07-31T07:53:13Z

+        enabled: !root.controller.busy
+        text: qsTranslate("AccountWizardWindow", "Cancel")
+        Layout.fillWidth: true
+        Layout.preferredWidth: 1


I don't think the preferred width should ever be 1 for these buttons

claucambra · 2026-07-31T07:54:13Z

+/*
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+import QtQuick
+
+BrowserAuthPage {
+    id: root
+
+    descriptionText: root.controller.infoText
+}


This component seems unnecessary to me...

claucambra · 2026-07-31T07:55:36Z

+    connect(this, &BrowserReAuthWindow::credentialsReady, this, &BrowserReAuthWindow::close, Qt::QueuedConnection);
+    connect(this, &BrowserReAuthWindow::cancelled, this, &BrowserReAuthWindow::close, Qt::QueuedConnection);
+
+    auto *const systray = Systray::instance();


I think we should avoid auto *const in places where const auto achieves the same thing and is clearer

claucambra · 2026-07-31T07:55:59Z

+        return;
+    }
+
+    auto *engine = systray->trayEngine();


Same here, this could also be const

claucambra · 2026-07-31T07:57:17Z

+    QVariantMap initialProperties;
+    initialProperties.insert(QStringLiteral("controller"), QVariant::fromValue<QObject *>(_controller));


We can construct a QVariantMap with the values inserted here directly, making this more concise and allowing us to constify this value

claucambra · 2026-07-31T07:58:23Z

+void BrowserReAuthWindow::show()
+{
+    if (_loadFailed || !_window) {
+        QTimer::singleShot(0, this, [this] {


QMetaObject::invokeMethod is better than this

claucambra · 2026-07-31T07:59:23Z

    readonly property int wizardStandaloneWindowMinimumWidth: 520
    readonly property int wizardStandaloneWindowMinimumHeight: 420
+    readonly property int accountWizardWindowWidth: 600
+    readonly property int accountWizardCompactHeight: 420


Any reason to not reuse wizardStandaloneWindowMinimumHeight ?

Rello added this to the 34.0.1 milestone Jul 27, 2026

Rello requested review from camilasan, claucambra, i2h3, mgallien and nilsding as code owners July 27, 2026 13:37

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

Rello added the design Design, UI, UX, etc. label Jul 27, 2026

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread src/gui/trayaccountpopup_qt.cpp Outdated

Comment thread test/testbrowserreauthcontroller.cpp

Rello force-pushed the bugfix/ReAuthDialog branch from f03bdf0 to c1957df Compare July 27, 2026 17:37

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread test/testbrowserreauthcontroller.cpp

Rello and others added 6 commits July 28, 2026 08:47

fix: unified WindowMinimizeButtonHint setting for all windows

a5cf702

Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

Merge branch 'master' into bugfix/ReAuthDialog

19e746c

fix: Fixed the missing QML resources in [testbrowserreauthcontroller.cpp

a1c200d

Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

Merge branch 'master' into bugfix/ReAuthDialog

30c69f1

fix: missing dependency in test

1fe626c

Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>

Merge branch 'master' into bugfix/ReAuthDialog

30c4b73

claucambra requested changes Jul 31, 2026

View reviewed changes

		QVariantMap initialProperties;
		initialProperties.insert(QStringLiteral("controller"), QVariant::fromValue<QObject *>(_controller));

Uh oh!

Conversation

Rello commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Rello commented Jul 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

sonarqubecloud Bot commented Jul 29, 2026

Quality Gate failed

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

claucambra Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rello commented Jul 27, 2026 •

edited

Loading