Open
Conversation
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
theoholl
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
grnd-alt
requested changes
Apr 14, 2026
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
did you test this? this breaks reactivity when deleting comments and when loading more comments than on initial fetch
Contributor
Author
|
Oh shoot, I'll review that. I thought I had tested deleting (adding, referencing, etc.) comments at least but I'll put this PR on hold until I tested more thoroughly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrated the
comment.jsVuex store to Pinia, following patterns from #7790.